-
Notifications
You must be signed in to change notification settings - Fork 584
Extend raw_id_tracker to support hash_zch_runtime_meta #3598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@FriedCosey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88600497. |
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Dec 8, 2025
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Differential Revision: D88600497
b035aae to
e40775f
Compare
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Dec 10, 2025
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Reviewed By: chouxi Differential Revision: D88600497
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Dec 10, 2025
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Reviewed By: chouxi Differential Revision: D88600497
e40775f to
0a85ce8
Compare
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Dec 15, 2025
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Reviewed By: chouxi Differential Revision: D88600497
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Reviewed By: chouxi Differential Revision: D88600497
0a85ce8 to
a69f356
Compare
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Dec 15, 2025
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Reviewed By: chouxi Differential Revision: D88600497
FriedCosey
pushed a commit
to FriedCosey/torchrec
that referenced
this pull request
Dec 15, 2025
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Reviewed By: chouxi Differential Revision: D88600497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/
This diff extends
raw_id_trackerto storehash_zch_runtime_metawhich will be alongside withhash_zch_identitieswhen presented.Note that it is possible that a mpzch table only has
hash_zch_identitieswithouthash_zch_runtime_metabut is not true vice versa.Differential Revision: D88600497